[Asterisk-code-review] bridge simple: Improve renegotiation success rate. (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6759 )

Change subject: bridge_simple: Improve renegotiation success rate.
......................................................................


Patch Set 1:

> It can end up trying to add a better codec in,

Aren't these the same codecs that were initially offered in the first invite? If the endpoint rejected or pruned them then why send them again?

 > and the resulting
 > topology is in preference order - so it can, potentially, improve
 > things.

Maybe if the formats were in the same order to being with. But what if the endpoints have the same format list, but in a different order? For instance, endpoint alice = g722, ulaw and bob = ulaw, g722 then bob's preference order get swapped if his topology changes to alice's.


-- 
To view, visit https://gerrit.asterisk.org/6759
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc0cc03e8bcfd0be8302f13b9f32d8268977f43
Gerrit-Change-Number: 6759
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 13 Oct 2017 22:09:12 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171013/f1e462e3/attachment.html>