[Asterisk-code-review] cdr.c: Defer getting ao2 global obj ref() until needed. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6784 )

Change subject: cdr.c: Defer getting ao2_global_obj_ref() until needed.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6784/1/main/cdr.c
File main/cdr.c:

https://gerrit.asterisk.org/#/c/6784/1/main/cdr.c@1682
PS1, Line 1682: 		is_congestion = mod_cfg
Can we make is_end_before_h_exten_set generic?
static int is_cdr_flag_set(int check_flag);

That way it can be used here to check for CDR_CONGESTION instead of duplicating it here.



-- 
To view, visit https://gerrit.asterisk.org/6784
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00c63b7ec233e5bfffd5d976f05568613d3c2365
Gerrit-Change-Number: 6784
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 12 Oct 2017 18:32:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171012/ddd6e70b/attachment.html>