[Asterisk-code-review] cdr.c: Set stringfields only if they are different. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6762 )

Change subject: cdr.c: Set stringfields only if they are different.
......................................................................


Patch Set 1:

> Would it be worth creating a macro or function for
 > ast_string_field_update which would only set if the value is being
 > changed?

I don't think it would be necessary.  Most places that set stringfields don't repeatedly set the strings.

CDRs are one of the few places that repeatedly set string fields.  CDRs set them very frequently and also have a tendency to set them to the same value.


-- 
To view, visit https://gerrit.asterisk.org/6762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ccb7e23f1488417e08cafe477755033eed65a7c
Gerrit-Change-Number: 6762
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 17:50:48 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171012/4e1c1523/attachment.html>