[Asterisk-code-review] cdr.c: Set stringfields only if they are different. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Thu Oct 12 12:29:12 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6762 )

Change subject: cdr.c: Set stringfields only if they are different.
......................................................................


Patch Set 1:

Would it be worth creating a macro or function for ast_string_field_update which would only set if the value is being changed?


-- 
To view, visit https://gerrit.asterisk.org/6762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ccb7e23f1488417e08cafe477755033eed65a7c
Gerrit-Change-Number: 6762
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Thu, 12 Oct 2017 17:29:12 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171012/afe44c56/attachment.html>


More information about the asterisk-code-review mailing list