[Asterisk-code-review] contrib/script/sip to pjsip: implement 'all' for allow/deny (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6741 )

Change subject: contrib/script/sip_to_pjsip: implement 'all' for allow/deny
......................................................................


Patch Set 1: Code-Review-1

This is referring to the wrong option in PJSIP, it is already called "disallow" there but this is using "deny". The "deny" option is used for ACLs.

I think it would also be helpful to see the source sip.conf and the resulting pjsip.conf both before and after the change.


-- 
To view, visit https://gerrit.asterisk.org/6741
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I99219478fb98f08751d769daaee0b7795118a5a6
Gerrit-Change-Number: 6741
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 16:38:46 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171011/a1532d03/attachment.html>