[Asterisk-code-review] astobj2: Add ao2 weakproxy find function. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Oct 10 19:12:30 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6710 )

Change subject: astobj2: Add ao2_weakproxy_find function.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6710/3/main/astobj2_container.c
File main/astobj2_container.c:

https://gerrit.asterisk.org/#/c/6710/3/main/astobj2_container.c@473
PS3, Line 473: 		__adjust_lock(c, orig_lock, 1);
I think the comment about keeping the upgraded lock is useful here since this is not what other functions are doing.



-- 
To view, visit https://gerrit.asterisk.org/6710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9da822049747275f5961b5c0a7f14e87157d65d8
Gerrit-Change-Number: 6710
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 11 Oct 2017 00:12:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/b11531a9/attachment.html>


More information about the asterisk-code-review mailing list