[Asterisk-code-review] sorcery: Use ao2 weakproxy to hold list of instances. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6712 )

Change subject: sorcery: Use ao2_weakproxy to hold list of instances.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Just the one nit specific to this weak proxy use patch.  Changes from the astobj2 __ao2_weakproxy_find() review are likely to affect this patch anyway.

https://gerrit.asterisk.org/#/c/6712/2/main/sorcery.c
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/6712/2/main/sorcery.c@210
PS2, Line 210: /*! \internal \brief Proxy object for sorcery */
I don't think it is valid doxygen to have \internal and \brief on the same line.  At least my editor doesn't like it. :)

/*
 * \internal
 * \brief blah
 */



-- 
To view, visit https://gerrit.asterisk.org/6712
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a150a4e13cee319d46b5a4654f95a4623a978f8
Gerrit-Change-Number: 6712
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 21:09:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/ca6bb8d3/attachment.html>