[Asterisk-code-review] cdr.c: Eliminated simple RAII VAR usages. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Oct 10 11:24:00 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6722 )

Change subject: cdr.c: Eliminated simple RAII_VAR usages.
......................................................................


Patch Set 1:

> I see these changes as being similar to whitespace changes. Should
 > these changes only go into trunk?

These are definitely not whitespace changes.  Some of the exit paths now do not call ao2_cleanup() when the cleanup object is always going to be NULL.


-- 
To view, visit https://gerrit.asterisk.org/6722
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I150505db307249a962987e7b941bdd369bb91f35
Gerrit-Change-Number: 6722
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 16:24:00 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/13d53bab/attachment.html>


More information about the asterisk-code-review mailing list