[Asterisk-code-review] ari/bridge: Add mute, dtmf suppression controls (asterisk[master])

[Seán C. McCord]

Seán C. McCord has posted comments on this change. ( https://gerrit.asterisk.org/6675 )

Change subject: ari/bridge: Add mute, dtmf suppression controls
......................................................................


Patch Set 2:

(4 comments)

Comments addressed, thanks.  How one misses `gofmt`...

https://gerrit.asterisk.org/#/c/6675/2/res/ari/resource_bridges.c
File res/ari/resource_bridges.c:

https://gerrit.asterisk.org/#/c/6675/2/res/ari/resource_bridges.c@223
PS2, Line 223:       if(!stasis_app_control_bridge_features_init(list->controls[i])) {
> Space after if:
Done


https://gerrit.asterisk.org/#/c/6675/2/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/6675/2/res/stasis/control.c@107
PS2, Line 107:    ast_bridge_features_destroy(control->bridge_features);
             : 
> Use tabs not spaces for indentation.  Spaces were used in many lines throug
Done


https://gerrit.asterisk.org/#/c/6675/2/res/stasis/control.c@1340
PS2, Line 1340:       ast_log(LOG_ERROR, "Error initializing bridge_features: %s\n",
              :             strerror(errno));
> Remove this error message.  It is redundant and errno is not set by the fun
Done


https://gerrit.asterisk.org/#/c/6675/2/res/stasis/control.c@1351
PS2, Line 1351:    if (absorb == 1) {
> Just use
Done



-- 
To view, visit https://gerrit.asterisk.org/6675
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4002adfb65c9a8027ee9e1a5f477e0f01cf9d61
Gerrit-Change-Number: 6675
Gerrit-PatchSet: 2
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 00:34:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/a213e19c/attachment-0001.html>