[Asterisk-code-review] ari/bridge: Add mute, dtmf suppression controls (asterisk[master])

[Seán C. McCord]

Seán C. McCord has posted comments on this change. ( https://gerrit.asterisk.org/6675 )

Change subject: ari/bridge: Add mute, dtmf suppression controls
......................................................................


Patch Set 2:

(5 comments)

Addressed all comments

https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c
File res/ari/resource_bridges.c:

https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c@202
PS1, Line 202: 	if (!bridge) {
> The extra whitespace can be deleted.
Done


https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c@224
PS1, Line 224:          stasis_app_control_absorb_dtmf_in_bridge(list->controls[i], args->absorb_dtmf);
             :          stasis_app_control_mute_in_bridge(list->controls[i], args->mute);
             :       }
             : 	}
             : 
             : 	for (i = 0; i < list->count; ++i) {
             : 		if
> Probably not a huge deal, but can this code be moved up into previous "for 
Done


https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@107
PS1, Line 107:    ast_bridge_features_destroy(control->bridge_features);
> The destructor needs to call to ast_bridge_features_destroy.
Done


https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@1178
PS1, Line 1178: 
              : 	ast_debug(3, "%s: Adding to bridge %s\n",
              : 		stasis_app_control_get_channel_id
> Probably better to move this below when the control is locked.
Done


https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@1201
PS1, Line 1201: 	}
              : 
              : 	ao2_lock(control);
              : 
> This off nominal path leaks features. Either you'll need a call to ast_brid
Done



-- 
To view, visit https://gerrit.asterisk.org/6675
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4002adfb65c9a8027ee9e1a5f477e0f01cf9d61
Gerrit-Change-Number: 6675
Gerrit-PatchSet: 2
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Mon, 09 Oct 2017 23:05:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/0189357b/attachment.html>