[Asterisk-code-review] res pjsip: Add REF DEBUG info to module references. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Oct 9 17:40:57 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6648 )

Change subject: res_pjsip: Add REF_DEBUG info to module references.
......................................................................


Patch Set 1:

> To not break ABI any released branches this is ported to still
 > needs a real function by the original name.

I hadn't planned on putting this one into 13/14/15.  It would still break the ABI in reverse.  If this change were made to 13.18.0, any binary modules compiled against 13.18.0+ would not load on older versions because the module would link against the new function which would not exist.  I'm pretty sure I've broken one of Digium's modules by doing that in the past.

When a module fails to unload we can just test against master to see the better REF_DEBUG info.


-- 
To view, visit https://gerrit.asterisk.org/6648
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63197ad33d1aebe60d12e0a6561718bdc54e4612
Gerrit-Change-Number: 6648
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 09 Oct 2017 22:40:57 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/72f246eb/attachment.html>


More information about the asterisk-code-review mailing list