[Asterisk-code-review] cdr.c: Replace redundant check with an ast assert() (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6706 )

Change subject: cdr.c: Replace redundant check with an ast_assert()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6706/1/main/cdr.c
File main/cdr.c:

https://gerrit.asterisk.org/#/c/6706/1/main/cdr.c@1630
PS1, Line 1630: 	ast_assert(cdr->party_b.snapshot
> So are you thinking that this can only happen via developer error?  There's
This is only called by cdr_object_update_party_b() which has explicitly done the same check as this assert before calling.

cdr_object_update_party_b()
{
...
	if (it_cdr->party_b.snapshot
		&& !strcasecmp(it_cdr->party_b.snapshot->name, party_b->name)) {
		it_cdr->fn_table->process_party_b(it_cdr, party_b);
	}
...
}



-- 
To view, visit https://gerrit.asterisk.org/6706
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0c53cdf5048227842846e0df9d2c19117c45618
Gerrit-Change-Number: 6706
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 09 Oct 2017 20:24:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/bf1c89c3/attachment-0001.html>