[Asterisk-code-review] res pjsip: Fix issues that prevented shutdown of modules. (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Oct 9 14:35:36 CDT 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6647 )

Change subject: res_pjsip: Fix issues that prevented shutdown of modules.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Giving -1 just so you'll see the question

https://gerrit.asterisk.org/#/c/6647/1/res/res_pjsip/pjsip_session.c
File res/res_pjsip/pjsip_session.c:

https://gerrit.asterisk.org/#/c/6647/1/res/res_pjsip/pjsip_session.c@105
PS1, Line 105: int ast_sip_session_add_supplements(struct ast_sip_session *session)
             : {
Thoughts on adding a pjsip session dependency to the base pjsip resource module?



-- 
To view, visit https://gerrit.asterisk.org/6647
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd5c19ec848010111afeab2436f9699da06ba6b
Gerrit-Change-Number: 6647
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 09 Oct 2017 19:35:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/3a51e95d/attachment.html>


More information about the asterisk-code-review mailing list