[Asterisk-code-review] Add .valgrindrc to .gitignore. (testsuite[master])

Jenkins2 asteriskteam at digium.com
Mon Oct 9 14:26:12 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/6676 )

Change subject: Add .valgrindrc to .gitignore.
......................................................................

Add .valgrindrc to .gitignore.

Tell git to ignore .valgrindrc and add comment to asterisk.py telling
valgrind users to add options to that config instead of modifying python
sources.

Change-Id: I8efff2f5d2c09dce91572653b7de04be966a1921
---
M .gitignore
M lib/python/asterisk/asterisk.py
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/.gitignore b/.gitignore
index 6a73616..137bce5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,3 +7,4 @@
 /tests/custom
 /fastagi
 /run-local.conf
+/.valgrindrc
diff --git a/lib/python/asterisk/asterisk.py b/lib/python/asterisk/asterisk.py
index dc575b4..2302d54 100755
--- a/lib/python/asterisk/asterisk.py
+++ b/lib/python/asterisk/asterisk.py
@@ -512,6 +512,8 @@
         if os.getenv("VALGRIND_ENABLE") == "true":
             valgrind_path = test_suite_utils.which('valgrind')
             if valgrind_path:
+                # No need to modify this array to add options.  Instead create
+                # .valgrindrc in the testsuite root directory.
                 cmd_prefix = [
                     valgrind_path,
                     '--xml=yes',

-- 
To view, visit https://gerrit.asterisk.org/6676
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8efff2f5d2c09dce91572653b7de04be966a1921
Gerrit-Change-Number: 6676
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171009/912c6004/attachment.html>


More information about the asterisk-code-review mailing list