[Asterisk-code-review] res pjsip: Fix leak of persistent endpoint references. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6657 )

Change subject: res_pjsip: Fix leak of persistent endpoint references.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6657/1/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/#/c/6657/1/res/res_pjsip/pjsip_configuration.c@1329
PS1, Line 1329: 	if (!endpoint->persistent) {
This may be an issue.  The persistent endpoint has a copy of the endpoint's aors.  If endpoint->persistent exists and it was the aors that changed on an endpoint, the persistent endpoint won't get updated.  In fact, I think persistent_endpoint_find_or_create is broken because it only copies the aors if the persistent endpoint had to be created and doesn't update them if it finds it in the container.



-- 
To view, visit https://gerrit.asterisk.org/6657
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59bbfc8da8a14d5f4af8c5bb1e71f8592ae823eb
Gerrit-Change-Number: 6657
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 06 Oct 2017 13:53:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171006/25f654cf/attachment.html>