[Asterisk-code-review] res pjsip: Fix leak of fake auth references. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6653 )

Change subject: res_pjsip: Fix leak of fake_auth references.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6653/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

https://gerrit.asterisk.org/#/c/6653/1/res/res_pjsip/pjsip_distributor.c@1148
PS1, Line 1148: 		ao2_cleanup(fake_auth);
How about just moving this outside the "if"?  That way you can get rid of the ao2_cleanup and the ao2_ref(fake_auth, -1).



-- 
To view, visit https://gerrit.asterisk.org/6653
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcf103b3680ad2d1d4610dcd6738eeaebf4d202
Gerrit-Change-Number: 6653
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 06 Oct 2017 13:41:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171006/eb00f434/attachment.html>