[Asterisk-code-review] vector: multiple evaluation of elem in AST VECTOR ADD SORTED. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Thu Oct 5 20:01:01 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6661 )

Change subject: vector: multiple evaluation of elem in AST_VECTOR_ADD_SORTED.
......................................................................


Patch Set 1:

Looks like this breaks one of the tests in test_vector.  I'm not sure how to deal with this.  The only real user of AST_VECTOR_ADD_SORTED is in res_pjproject, so maybe the test which doesn't compile should just be removed?


-- 
To view, visit https://gerrit.asterisk.org/6661
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib960d7f5576f9e1a3c478ecb48995582a574e06d
Gerrit-Change-Number: 6661
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 06 Oct 2017 01:01:01 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171005/92ce0cf6/attachment.html>


More information about the asterisk-code-review mailing list