[Asterisk-code-review] dtls: Add support for ephemeral DTLS certificates (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6640 )

Change subject: dtls: Add support for ephemeral DTLS certificates
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6640/2/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6640/2/channels/chan_sip.c@32241
PS2, Line 32241: 	default_dtls_cfg.certtype = ast_strdup("file");
Does this need to be a string? Would an enum work?


https://gerrit.asterisk.org/#/c/6640/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/#/c/6640/2/res/res_pjsip/pjsip_configuration.c@1372
PS2, Line 1372: 
For the webrtc option I think this should be changed to explicitly set the cert type to ecdsa if a certfile was not provided.



-- 
To view, visit https://gerrit.asterisk.org/6640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4
Gerrit-Change-Number: 6640
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 14:17:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171004/f79ca3d7/attachment.html>