[Asterisk-code-review] res pjsip caller id chan sip: Comply to RFC 3323 values for ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6642 )

Change subject: res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6642/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/6642/2//COMMIT_MSG@15
PS2, Line 15: Per feedback changed "privacy==NULL" to "!privacy". Will look into
            : how to cherry pick to 14/15/master (and chan_sip.c patch to 11 LTS).
Remove these two lines.

The commit message is part of the review and is EXACTLY what will be committed.  You should not chronicle changes to your patch in the commit message.  That is what gerrit is doing for you automatically.


https://gerrit.asterisk.org/#/c/6642/2/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6642/2/channels/chan_sip.c@18029
PS2, Line 18029: 	if (!ast_strlen_zero(privacy) && strncmp(privacy, "none", 4)) {
I think the comparison should be:
if (!ast_strlen_zero(privacy) && strcasecmp(privacy, "none")) {
}

The privacy[] string will always be null terminated and if it isn't "none" then the number should be prohibited.  We probably should be case insensitive just in case.  We certainly are in the pjsip code.



-- 
To view, visit https://gerrit.asterisk.org/6642
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56
Gerrit-Change-Number: 6642
Gerrit-PatchSet: 2
Gerrit-Owner: dtryba <daniel at tryba.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 16:59:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171003/3fe39d8b/attachment-0001.html>