[Asterisk-code-review] res pjsip caller id chan sip: Comply to RFC 3323 values for ... (asterisk[13])

Sean Bright asteriskteam at digium.com
Tue Oct 3 08:56:40 CDT 2017


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/6642 )

Change subject: res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

This will need to be cherry picked to 14, 15, and master

https://gerrit.asterisk.org/#/c/6642/1/res/res_pjsip_caller_id.c
File res/res_pjsip_caller_id.c:

https://gerrit.asterisk.org/#/c/6642/1/res/res_pjsip_caller_id.c@152
PS1, Line 152: 	if (privacy==NULL || !pj_stricmp2(&privacy->hvalue, "none")) {
Change this to:

 if (!privacy || ...



-- 
To view, visit https://gerrit.asterisk.org/6642
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56
Gerrit-Change-Number: 6642
Gerrit-PatchSet: 1
Gerrit-Owner: dtryba <daniel at tryba.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 13:56:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171003/a4d864c8/attachment.html>


More information about the asterisk-code-review mailing list