[Asterisk-code-review] app queue.c: Fix announcements when announce-to-first-user n... (asterisk[13])

[Stefan Engström]

Stefan Engström has posted comments on this change. ( https://gerrit.asterisk.org/6634 )

Change subject: app_queue.c: Fix announcements when announce-to-first-user not enabled.
......................................................................


Patch Set 1:

Aha, thanks for clearing a few things up. Good point  noticing that announce-to-first-user is off by default. I did not consider that when guessing the impact of ASTERISK-27216. I based the changes of ASTERISK-27216 off what I thought was the most logical interpretation of the variable announce-to-first-user and at the time I believed the default value was 1 (we have always had it on explicitly). My interpretation seems to be more in line with what the description for the parameter is in ./configs/samples/queues.conf.sample (...If enabled, play announcements to the first user waiting in the Queue...). Although that does not explicidly say "If and only if enabled", it's sort of implied... and I interpret announcements as both position and periodic announcements. If one instead uses how asterisk has actually worked for a long time as a source of truth for expected behaviour, I think I understand your perspective better. If we would go towards your line play; I think renaming variables to reflect their purpose and totally rewriting the parameter description in queues.conf would be in order. Going towards my line of play would definitely need to address the fact most asterisk users probably have that parameter set to 0 and still expect their head callers to hear periodic info once in a while due to historic reasons...


-- 
To view, visit https://gerrit.asterisk.org/6634
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaeb7dbea8ae7073086b775fbafe0625b000b10a
Gerrit-Change-Number: 6634
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
Gerrit-Comment-Date: Mon, 02 Oct 2017 20:11:09 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171002/63091505/attachment.html>