[Asterisk-code-review] bridge basic: Display failed target (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7392 )

Change subject: bridge_basic: Display failed target
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c
File main/bridge_basic.c:

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c@3352
PS1, Line 3352: 		ast_log(LOG_WARNING, "Unable to acquire target extension for attended transfer: '%s@%s'\n", exten, props->context);
The contents of exten are undefined at this point so adding it to the message doesn't help any.  There are a couple debug messages in grab_transfer() around line 3220 that do output this information alredy when an invalid or no extension is dialed.  They are debug messages because they are output for each failed attempt by the user.  Maybe the messages should be promoted to ast_verb(3 or 4)?



-- 
To view, visit https://gerrit.asterisk.org/7392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880
Gerrit-Change-Number: 7392
Gerrit-PatchSet: 1
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 15:02:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171129/5e8be75f/attachment.html>