[Asterisk-code-review] autoconf: Use m4 conditional in AST GCC ATTRIBUTE. (asterisk[15])

George Joseph asteriskteam at digium.com
Tue Nov 28 09:27:47 CST 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7385 )

Change subject: autoconf: Use m4 conditional in AST_GCC_ATTRIBUTE.
......................................................................


Patch Set 1: Code-Review-1

these reviews all conflict.  i think you would be better off with 1 patch for the conditionals and one for the AC_CONFIG_AUX_DIR fix


-- 
To view, visit https://gerrit.asterisk.org/7385
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie70134f5795f38cb6fbd46684971e1fa847bc774
Gerrit-Change-Number: 7385
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 28 Nov 2017 15:27:47 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171128/f3a14fe3/attachment-0001.html>


More information about the asterisk-code-review mailing list