[Asterisk-code-review] loader: Fix comments in struct ast module. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Tue Nov 21 07:14:33 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7330 )

Change subject: loader: Fix comments in struct ast_module.
......................................................................

loader: Fix comments in struct ast_module.

Make the comments follow doxygen format, move comments to the line
before each field they describe.

Change-Id: Ic445468398b5e88f13910f7c2f70bd15aad33a27
---
M main/loader.c
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/main/loader.c b/main/loader.c
index 7b7066f..7d792b0 100644
--- a/main/loader.c
+++ b/main/loader.c
@@ -120,15 +120,21 @@
 struct ast_module {
 	const struct ast_module_info *info;
 #ifdef REF_DEBUG
-	/* Used to get module references into REF_DEBUG logs */
+	/*! Used to get module references into refs log */
 	void *ref_debug;
 #endif
-	void *lib;					/* the shared lib, or NULL if embedded */
-	int usecount;					/* the number of 'users' currently in this module */
-	struct module_user_list users;			/* the list of users in the module */
+	/*! The shared lib. */
+	void *lib;
+	/*! Number of 'users' and other references currently holding the module. */
+	int usecount;
+	/*! List of users holding the module. */
+	struct module_user_list users;
 	struct {
+		/*! The module running and ready to accept requests. */
 		unsigned int running:1;
+		/*! The module has declined to start. */
 		unsigned int declined:1;
+		/*! This module is being held open until it's time to shutdown. */
 		unsigned int keepuntilshutdown:1;
 	} flags;
 	AST_LIST_ENTRY(ast_module) list_entry;

-- 
To view, visit https://gerrit.asterisk.org/7330
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic445468398b5e88f13910f7c2f70bd15aad33a27
Gerrit-Change-Number: 7330
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171121/81e8c7c8/attachment-0001.html>


More information about the asterisk-code-review mailing list