[Asterisk-code-review] chan sip: ICE contained square brackets around IPv6 addresses. (asterisk[master])

Alexander Traud asteriskteam at digium.com
Tue Nov 21 03:40:37 CST 2017


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7300 )

Change subject: chan_sip: ICE contained square brackets around IPv6 addresses.
......................................................................


Patch Set 1: Code-Review-1

13 code lines next, *host instead of *addr_remote is used again. Although that is never called with an IPv6, for consistency, I am going to change/fix that as well. Until then, I block this change by giving it a -1.


-- 
To view, visit https://gerrit.asterisk.org/7300
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeed89b4fa05d94c5f0ec2d3b7cd6e93d2d5a8f7
Gerrit-Change-Number: 7300
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 21 Nov 2017 09:40:37 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171121/61e6ea3d/attachment.html>


More information about the asterisk-code-review mailing list