[Asterisk-code-review] res parking: Make load pri explicit. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7312 )

Change subject: res_parking: Make load_pri explicit.
......................................................................


Patch Set 1:

> > Whatever is done needs cherry-picks, I'll do that once I get
 > > feedback on what we want to do:
 > > 1) Just explicitly set load_pri = 0, maintain current load order.
 > > 2) Use AST_MODPRI_CHANNEL_DEPEND or some other priority to allow
 > > res_parking to use realtime modules without having to preload
 > them.
 > >
 > 
 > Seems like an oversight to me, and the priority could be raised.
 > Might even be able to make it just AST_MODPRI_DEFAULT as it appears
 > no other modules directly call/depend on it (unless it's done
 > through a registered handler through the core parking stuff that's
 > called at load time)

res_parking is a device state provider.

 > 
 > > Another option would be to keep it at 0 for 13/15, give it a more
 > > appropriate value for master.
 > 
 > This might be the best approach since as it guarantees not
 > potentially breaking people during minor upgrades.  Although if
 > anything it'd be a config change, so might be fine? Either way
 > probably worth a mention in the UPGRADE.txt

I'll go with this, 13/15 will get the NOOP change.


-- 
To view, visit https://gerrit.asterisk.org/7312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I297b6fb3ff6993ec004e667b22a74f5925906259
Gerrit-Change-Number: 7312
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 21 Nov 2017 00:17:55 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171120/e24e2008/attachment.html>