[Asterisk-code-review] CLI: Create ast cli completion add function. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7259 )

Change subject: CLI: Create ast_cli_completion_add function.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7259/2/main/cli.c
File main/cli.c:

https://gerrit.asterisk.org/#/c/7259/2/main/cli.c@2561
PS2, Line 2561: if (cli_completion_vector_add(vec, retstr)) {
              : 			goto vector_cleanup;
              : 		}
Should the completion storage be set to NULL here (before calling cleanup) if adding fails?



-- 
To view, visit https://gerrit.asterisk.org/7259
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I73d26d270bbbe1e3e6390799cfc1b639e39cceec
Gerrit-Change-Number: 7259
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 20 Nov 2017 21:23:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171120/16bf39d0/attachment-0001.html>