[Asterisk-code-review] CLI: Remove calls to ast cli generator. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7258 )

Change subject: CLI: Remove calls to ast_cli_generator.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7258/1/tests/test_substitution.c
File tests/test_substitution.c:

https://gerrit.asterisk.org/#/c/7258/1/tests/test_substitution.c@309
PS1, Line 309: 	funcs = ast_cli_completion_vector("core show function", "");
             : 
             : 	/* Skip "best match" element 0 */
             : 	for (i = 1; i < AST_VECTOR_SIZE(funcs); i++) {
> Need a NULL check here. If "funcs" is NULL then the vector size check will 
I'll update this review once ast_cli_completion_vector is merged, I don't want to cause a rebase since it already has +2.



-- 
To view, visit https://gerrit.asterisk.org/7258
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cd6b93905363cf7a33a2d2b0e2a8f8446d9f248
Gerrit-Change-Number: 7258
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 20 Nov 2017 21:11:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171120/0ca867d5/attachment.html>