[Asterisk-code-review] res rtp asterisk.c: Fix rtp source address learning for brok... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7237 )

Change subject: res_rtp_asterisk.c: Fix rtp source address learning for broken clients
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7237/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/7237/3/res/res_rtp_asterisk.c@6569
PS3, Line 6569: 		if ((sscanf(s, "%d", &learning_min_sequential) <= 1) || learning_min_sequential <= 1) {
sscanf() returns the number of items converted or EOF (-1) in case of error.

The sscanf() <= 1 test will always be true and force setting the default.  If you're going to change the sscanf() return check then change it to sscanf() != 1 which is better than the original test anyway.



-- 
To view, visit https://gerrit.asterisk.org/7237
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If778fe07678a6fd2041eaca7cd78267d0ef4fc6c
Gerrit-Change-Number: 7237
Gerrit-PatchSet: 3
Gerrit-Owner: Pirmin Walthert <infos at nappsoft.ch>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 17 Nov 2017 17:13:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171117/95ea780c/attachment.html>