[Asterisk-code-review] acl: Fix allocation related issues. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7239 )

Change subject: acl: Fix allocation related issues.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/7239/3/main/acl.c
File main/acl.c:

https://gerrit.asterisk.org/#/c/7239/3/main/acl.c@563
PS3, Line 563:  * \brief Used by ast_append_ha to avoid ast_strdupa in a loop.
> How about a note that this function only gets called if debug level >= 3.
This note is silly.  What does the called care about the caller?  What if I wanted to call it when the debug level is 2?  This functions job it to simply post a log message.  It is up to the caller to decide if it needs to be posted.



-- 
To view, visit https://gerrit.asterisk.org/7239
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia19eaaeb0b139ff7ce7b971c7550e85c8b78ab76
Gerrit-Change-Number: 7239
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 17 Nov 2017 16:58:00 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171117/156451f2/attachment-0001.html>