[Asterisk-code-review] pjsip: Add patch to allow all transports to be destroyed. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7173 )

Change subject: pjsip: Add patch to allow all transports to be destroyed.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/7173/2/third-party/pjproject/patches/0030-sip_transport-Destroy-transports-not-in-hash.patch
File third-party/pjproject/patches/0030-sip_transport-Destroy-transports-not-in-hash.patch:

https://gerrit.asterisk.org/#/c/7173/2/third-party/pjproject/patches/0030-sip_transport-Destroy-transports-not-in-hash.patch@5
PS2, Line 5: @@ -957,7 +957,21 @@ static pj_bool_t is_transport_valid(pjsip_tpmgr *tpmgr, pjsip_transport *tp,
This is called by two places.  pjsip_transport_add_ref() and pjsip_transport_dec_ref().  From the description the pjsip_transport_dec_ref() needs to check the tp_list.  Does the pjsip_transport_add_ref() need to check the tp_list?



-- 
To view, visit https://gerrit.asterisk.org/7173
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5c2bb60226df0ef1c8851359ed8d4cd64469429
Gerrit-Change-Number: 7173
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 14 Nov 2017 01:11:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/604180a0/attachment.html>