[Asterisk-code-review] sorcery: Add ast sorcery retrieve by prefix() (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7162 )

Change subject: sorcery: Add ast_sorcery_retrieve_by_prefix()
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

The -1 is not about the retrieve_regex fallback comment, I'm not sure that's worth a -1.  See the master review for real findings.

https://gerrit.asterisk.org/#/c/7162/2/main/sorcery.c
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/7162/2/main/sorcery.c@2021
PS2, Line 2021: 		if (!wizard->wizard->callbacks.retrieve_prefix) {
What about if callbacks provides retrieve_regex but no retrieve_prefix?  In that case should we try using the regex callback?  The concern is that anything which uses this function will not see any data provided by "old" wizards.

Not sure this needs to be addressed even for 13/15, just worth mentioning.  I'm assuming that master should not deal with this and all wizards will be expected to provide the retrieve_prefix callback.



-- 
To view, visit https://gerrit.asterisk.org/7162
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79
Gerrit-Change-Number: 7162
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 13 Nov 2017 19:08:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/8cf15268/attachment.html>