[Asterisk-code-review] bundled pjproject: sip parser: Fix return code in pjsip fin... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7180 )

Change subject: bundled_pjproject: sip_parser:  Fix return code in pjsip_find_msg
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7180/2/third-party/pjproject/patches/0021-sip_parser-Fix-return-code-in-pjsip_find_msg-and-add.patch
File third-party/pjproject/patches/0021-sip_parser-Fix-return-code-in-pjsip_find_msg-and-add.patch:

https://gerrit.asterisk.org/#/c/7180/2/third-party/pjproject/patches/0021-sip_parser-Fix-return-code-in-pjsip_find_msg-and-add.patch@35
PS2, Line 35: +    pj_status_t status = PJSIP_EMISSINGHDR;
status should be made volatile for completeness even though I think it is safe.  The CATCH block doesn't unconditionally set a value but the only exceptions that could happen here are covered by the else-if ladder.



-- 
To view, visit https://gerrit.asterisk.org/7180
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: If82ba9de921e3d57df9c68cf96ee45ccc1491f7a
Gerrit-Change-Number: 7180
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 17:13:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/af9e0a74/attachment.html>