[Asterisk-code-review] Fix realtime mapping of yesno boolean types (asterisk[13])

Florian Floimair asteriskteam at digium.com
Mon Nov 13 05:38:44 CST 2017


Hello Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7201

to look at the new patch set (#2).

Change subject: Fix realtime mapping of yesno boolean types
......................................................................

Fix realtime mapping of yesno boolean types

In a realtime database scenario with push configuration
(using ARI) boolean values that are supposed to match to
an Enum in the database with "yes"/"no" values are not
transferred to the database. This in turn causes
Asterisk to use default values for all affected entries.

The reason for this is that they use the type OPT_BOOL_T
in sorcery which translates to "true"/"false" when transformed
into strings.

This fix therefore changes all affected values to use the
OPT_YESNO_T type which correctly translates into "yes"/"no"
and is therefore correctly inserted into the database.

ASTERISK-27407 #close

Change-Id: Ia2e8e0ae90ce518a3b940ff1ce427a5696e560f2
---
M res/res_pjsip/config_transport.c
M res/res_pjsip/location.c
M res/res_pjsip/pjsip_configuration.c
M res/res_pjsip_endpoint_identifier_ip.c
M res/res_pjsip_outbound_registration.c
M res/res_pjsip_publish_asterisk.c
6 files changed, 46 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/01/7201/2
-- 
To view, visit https://gerrit.asterisk.org/7201
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia2e8e0ae90ce518a3b940ff1ce427a5696e560f2
Gerrit-Change-Number: 7201
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/0f3b1391/attachment-0001.html>


More information about the asterisk-code-review mailing list