[Asterisk-code-review] CLI: Create ast cli completion vector. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Thu Nov 9 15:15:55 CST 2017


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7166

to look at the new patch set (#2).

Change subject: CLI: Create ast_cli_completion_vector.
......................................................................

CLI: Create ast_cli_completion_vector.

This is a rewrite of ast_cli_completion_matches using a vector to build
the list.  The original function calls the vector version, NULL
terminates the vector and extracts the elements array.

One change in behavior the results are now sorted and deduplicated. This
will solve bugs where some duplicate checking was done before the list
was sorted.

Change-Id: Iede20c5b4d965fa5ec71fda136ce9425eeb69519
---
M include/asterisk/cli.h
M main/cli.c
2 files changed, 99 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/66/7166/2
-- 
To view, visit https://gerrit.asterisk.org/7166
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iede20c5b4d965fa5ec71fda136ce9425eeb69519
Gerrit-Change-Number: 7166
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171109/6c25408d/attachment.html>


More information about the asterisk-code-review mailing list