[Asterisk-code-review] sorcery: Add ast sorcery retrieve by prefix() (asterisk[13])

Corey Farrell asteriskteam at digium.com
Thu Nov 9 14:02:10 CST 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7162 )

Change subject: sorcery: Add ast_sorcery_retrieve_by_prefix()
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7162/1/include/asterisk/sorcery.h
File include/asterisk/sorcery.h:

https://gerrit.asterisk.org/#/c/7162/1/include/asterisk/sorcery.h@317
PS1, Line 317: 	void (*retrieve_prefix)(const struct ast_sorcery *sorcery,
This is an ABI change.  A module built against the previous header would not reserve space for this pointer, so sorcery.c could get anything by reading this variable.



-- 
To view, visit https://gerrit.asterisk.org/7162
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79
Gerrit-Change-Number: 7162
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 09 Nov 2017 20:02:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171109/0f4c77b0/attachment.html>


More information about the asterisk-code-review mailing list