[Asterisk-code-review] res pjsip exten state: Check for vector append failure. (asterisk[15])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7077 )

Change subject: res_pjsip_exten_state: Check for vector append failure.
......................................................................

res_pjsip_exten_state: Check for vector append failure.

Release reference to publisher if we fail to add it to the vector.

Change-Id: I64dff3f481b67b9884f37cadba7a5ccf23d084f3
---
M res/res_pjsip_exten_state.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, approved



diff --git a/res/res_pjsip_exten_state.c b/res/res_pjsip_exten_state.c
index 95a4082..3e75613 100644
--- a/res/res_pjsip_exten_state.c
+++ b/res/res_pjsip_exten_state.c
@@ -729,8 +729,11 @@
 		}
 
 		ao2_ref(publisher, +1);
-		AST_VECTOR_APPEND(&pub_data->pubs, publisher);
-		ast_debug(5, "'%s' will publish exten state\n", publisher->name);
+		if (AST_VECTOR_APPEND(&pub_data->pubs, publisher)) {
+			ao2_ref(publisher, -1);
+		} else {
+			ast_debug(5, "'%s' will publish exten state\n", publisher->name);
+		}
 	}
 	ao2_iterator_destroy(&publisher_iter);
 

-- 
To view, visit https://gerrit.asterisk.org/7077
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I64dff3f481b67b9884f37cadba7a5ccf23d084f3
Gerrit-Change-Number: 7077
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171108/a2857997/attachment.html>