[Asterisk-code-review] CLI: Remove unused internal command. (asterisk[15])

Joshua Colp asteriskteam at digium.com
Tue Nov 7 18:31:47 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7026 )

Change subject: CLI: Remove unused internal command.
......................................................................

CLI: Remove unused internal command.

The internal CLI command "_command complete" was last used by Asterisk
0.2.0.  Since then we've been using "_command nummatches" and "_command
matchesarray".

Change-Id: I682fe1e21a24a3bb5bd04146e639f1c5866bcfce
---
M main/cli.c
1 file changed, 0 insertions(+), 27 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, approved



diff --git a/main/cli.c b/main/cli.c
index 0896181..5c16e8b 100644
--- a/main/cli.c
+++ b/main/cli.c
@@ -1362,31 +1362,6 @@
 	return CLI_SUCCESS;
 }
 
-static char *handle_commandcomplete(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)
-{
-	char *buf;
-	switch (cmd) {
-	case CLI_INIT:
-		e->command = "_command complete";
-		e->usage =
-			"Usage: _command complete \"<line>\" text state\n"
-			"       This function is used internally to help with command completion and should.\n"
-			"       never be called by the user directly.\n";
-		return NULL;
-	case CLI_GENERATE:
-		return NULL;
-	}
-	if (a->argc != 5)
-		return CLI_SHOWUSAGE;
-	buf = __ast_cli_generator(a->argv[2], a->argv[3], atoi(a->argv[4]), 0);
-	if (buf) {
-		ast_cli(a->fd, "%s", buf);
-		ast_free(buf);
-	} else
-		ast_cli(a->fd, "NULL\n");
-	return CLI_SUCCESS;
-}
-
 struct channel_set_debug_args {
 	int fd;
 	int is_off;
@@ -1817,8 +1792,6 @@
 static char *handle_help(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a);
 
 static struct ast_cli_entry cli_cli[] = {
-	/* Deprecated, but preferred command is now consolidated (and already has a deprecated command for it). */
-	AST_CLI_DEFINE(handle_commandcomplete, "Command complete"),
 	AST_CLI_DEFINE(handle_commandnummatches, "Returns number of command matches"),
 	AST_CLI_DEFINE(handle_commandmatchesarray, "Returns command matches array"),
 

-- 
To view, visit https://gerrit.asterisk.org/7026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I682fe1e21a24a3bb5bd04146e639f1c5866bcfce
Gerrit-Change-Number: 7026
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171107/504331ce/attachment.html>


More information about the asterisk-code-review mailing list