[Asterisk-code-review] ast coredumper: Add ability to use directory other than /tmp (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Tue Nov 7 09:55:13 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7090 )

Change subject: ast_coredumper:  Add ability to use directory other than /tmp
......................................................................


Patch Set 1: Code-Review-1

(10 comments)

https://gerrit.asterisk.org/#/c/7090/1/configs/samples/ast_debug_tools.conf.sample
File configs/samples/ast_debug_tools.conf.sample:

https://gerrit.asterisk.org/#/c/7090/1/configs/samples/ast_debug_tools.conf.sample@26
PS1, Line 26: # produced from a running process, teh default is /tmp. 
s/teh/the

Also red blob at the end of line.


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper
File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@139
PS1, Line 139: 	
Remove the extra spaces here


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@183
PS1, Line 183: 	# produced from a running process, the default is /tmp. 
Remove extra space at eol.


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@403
PS1, Line 403: 	
Red blob


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@407
PS1, Line 407: 	
red blobness


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@423
PS1, Line 423: 	
Moar whitespace


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@428
PS1, Line 428: 		
extra  whitespace


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@431
PS1, Line 431: 		
remove whitespace


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@435
PS1, Line 435: 		
Another whitespace


https://gerrit.asterisk.org/#/c/7090/1/contrib/scripts/ast_coredumper@466
PS1, Line 466: 	
last one (whitespace)!



-- 
To view, visit https://gerrit.asterisk.org/7090
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b2553319df61caea5b313d084f51978f730b4c
Gerrit-Change-Number: 7090
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 15:55:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171107/0ef8ea88/attachment.html>


More information about the asterisk-code-review mailing list