[Asterisk-code-review] res pjsip history: Fix multiple leaks on vector append failure. (asterisk[master])
Corey Farrell
asteriskteam at digium.com
Mon Nov 6 18:15:07 CST 2017
Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7086 )
Change subject: res_pjsip_history: Fix multiple leaks on vector append failure.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c
File res/res_pjsip_history.c:
https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c@968
PS1, Line 968: /* BUGBUG: possible leak on failure? */
This spot I was not sure what to do. It seems like we leak here but I'm unsure how to deal with it. Will cherry-pick once I have an idea what to do in this spot.
--
To view, visit https://gerrit.asterisk.org/7086
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8d5183ace284095cc721f3b1fb32ade3f940f
Gerrit-Change-Number: 7086
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 00:15:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171106/47851977/attachment-0001.html>
More information about the asterisk-code-review
mailing list