[Asterisk-code-review] res pjproject: Handle error from adding to the buildopts vec... (asterisk[13])

Corey Farrell asteriskteam at digium.com
Mon Nov 6 17:20:25 CST 2017


Corey Farrell has uploaded this change for review. ( https://gerrit.asterisk.org/7057


Change subject: res_pjproject: Handle error from adding to the buildopts vector.
......................................................................

res_pjproject: Handle error from adding to the buildopts vector.

Change-Id: I076c7bd207c7989a23005395ce1735392657be65
---
M res/res_pjproject.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/57/7057/1

diff --git a/res/res_pjproject.c b/res/res_pjproject.c
index fa99919..c2f7c84 100644
--- a/res/res_pjproject.c
+++ b/res/res_pjproject.c
@@ -229,11 +229,16 @@
 
 static void capture_buildopts_cb(int level, const char *data, int len)
 {
+	char *dup;
+
 	if (strstr(data, "Teluu") || strstr(data, "Dumping")) {
 		return;
 	}
 
-	AST_VECTOR_ADD_SORTED(&buildopts, ast_strdup(ast_skip_blanks(data)), strcmp);
+	dup = ast_strdup(ast_skip_blanks(data));
+	if (AST_VECTOR_ADD_SORTED(&buildopts, dup, strcmp)) {
+		ast_free(dup);
+	}
 }
 
 #pragma GCC diagnostic ignored "-Wformat-nonliteral"

-- 
To view, visit https://gerrit.asterisk.org/7057
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I076c7bd207c7989a23005395ce1735392657be65
Gerrit-Change-Number: 7057
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171106/30960d53/attachment.html>


More information about the asterisk-code-review mailing list