[Asterisk-code-review] res pjsip pubsub: Ensure remote URI contains URI only. (asterisk[15])

Kevin Harwell asteriskteam at digium.com
Mon Nov 6 11:51:20 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7011 )

Change subject: res_pjsip_pubsub: Ensure remote URI contains URI only.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7011/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/7011/1/res/res_pjsip_pubsub.c@2448
PS1, Line 2448: pjsip_uri_print(PJSIP_URI_IN_FROMTO_HDR, uri, buf, size);
Prob should check the result of the print function just in case. As it is if this returns -1 no '\0' gets put on the end.



-- 
To view, visit https://gerrit.asterisk.org/7011
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: If1d0cd6630f0a264856d31d2a67933109187a017
Gerrit-Change-Number: 7011
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 06 Nov 2017 17:51:20 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171106/db22c713/attachment.html>


More information about the asterisk-code-review mailing list