[Asterisk-code-review] res pjsip: Avoid crash when contact uri is empty string (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6997 )

Change subject: res_pjsip:  Avoid crash when contact uri is empty string
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6997/3/res/res_pjsip/location.c
File res/res_pjsip/location.c:

https://gerrit.asterisk.org/#/c/6997/3/res/res_pjsip/location.c@1223
PS3, Line 1223: 		ast_log(LOG_ERROR, "A contact on AOR '%s' is empty\n",
Actually, it's not AOR at all.  It's a dynamic contact read from astdb or a database.
So...
"A URI on dynamic contact '%s' is empty\n"

Sorry for the churn.


https://gerrit.asterisk.org/#/c/6997/3/res/res_pjsip/location.c@1224
PS3, Line 1224: object
This should be "contact" for clarity and consistency.



-- 
To view, visit https://gerrit.asterisk.org/6997
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0309bdc6b697c73c9c736e1caec910b77ca69f5
Gerrit-Change-Number: 6997
Gerrit-PatchSet: 3
Gerrit-Owner: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 06 Nov 2017 13:27:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171106/4c520072/attachment.html>