[Asterisk-code-review] res stasis device state.c: Pull stack alloc out of loop. (asterisk[13])

Sean Bright asteriskteam at digium.com
Fri Nov 3 12:12:30 CDT 2017


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/6976 )

Change subject: res_stasis_device_state.c: Pull stack alloc out of loop.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6976/1/res/res_stasis_device_state.c
File res/res_stasis_device_state.c:

https://gerrit.asterisk.org/#/c/6976/1/res/res_stasis_device_state.c@176
PS1, Line 176: 	struct ast_str *device = ast_str_alloca(DEVICE_STATE_SIZE);
What's the benefit of this over a char[]?



-- 
To view, visit https://gerrit.asterisk.org/6976
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia27e64a884afa0f50b9ffdb1cf23da6bfa51ffdf
Gerrit-Change-Number: 6976
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 03 Nov 2017 17:12:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171103/e4796ee9/attachment.html>


More information about the asterisk-code-review mailing list