[Asterisk-code-review] bridge native rtp: Improved handling of channel hold/unhold (asterisk[13])

[Vitezslav Novy]

Vitezslav Novy has posted comments on this change. ( https://gerrit.asterisk.org/6892 )

Change subject: bridge_native_rtp: Improved handling of channel hold/unhold
......................................................................


Patch Set 2:

I have ready patch for tests. But have noticed that in hold using IP restrict scenario asterisk with this patch does not send reinvite with 0.0.0.0 media destination address to phone on hold. So the phone stays in sendrecv mode like in media restrict scenario. I'm not sure if it is OK.


-- 
To view, visit https://gerrit.asterisk.org/6892
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I811fcadd40912bf8814560b8b02582357f19ed5a
Gerrit-Change-Number: 6892
Gerrit-PatchSet: 2
Gerrit-Owner: Vitezslav Novy <a1 at vnovy.net>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Vitezslav Novy <a1 at vnovy.net>
Gerrit-Comment-Date: Thu, 02 Nov 2017 08:54:37 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171102/fc520363/attachment.html>