[Asterisk-code-review] Modules: Additional improvements to CLI completion. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Nov 1 18:40:03 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6942 )

Change subject: Modules: Additional improvements to CLI completion.
......................................................................


Patch Set 3:

> What did the commands show before?
 > When I type "module load res_pjsip<tab>" I get all res_pjsip
 > modules, including res_pjsip itself.  Shouldn't only modules that
 > CAN be loaded be shown?

'module load' previously showed all files in the modules directory, my first patch was ineffective for module load.  I believe it the CLI completion now for modules now gives all the correct options and no wrong options.


-- 
To view, visit https://gerrit.asterisk.org/6942
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea3e00054461484196c46f688f02635cc886bad1
Gerrit-Change-Number: 6942
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 01 Nov 2017 23:40:03 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171101/36e63ad6/attachment.html>


More information about the asterisk-code-review mailing list