[Asterisk-code-review] res agi: Fix malformed AGI usage response (asterisk[master])

Jenkins2 asteriskteam at digium.com
Thu May 25 15:23:19 CDT 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5699 )

Change subject: res_agi: Fix malformed AGI usage response
......................................................................


res_agi: Fix malformed AGI usage response

If the generated XML documentation for a command does not end with a \n,
the postamble of the usage message does not appear on its own line.

ASTERISK-25662 #close

Change-Id: If190f1e9e37fe215fed95897d78d4a6e142b0020
---
M res/res_agi.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Jenkins2: Approved for Submit
  Joshua Colp: Looks good to me, approved



diff --git a/res/res_agi.c b/res/res_agi.c
index 557f349..fab9f36 100644
--- a/res/res_agi.c
+++ b/res/res_agi.c
@@ -4037,7 +4037,7 @@
 				ast_agi_send(agi->fd, chan, "520 Invalid command syntax.  Proper usage not available.\n");
 			} else {
 				ast_agi_send(agi->fd, chan, "520-Invalid command syntax.  Proper usage follows:\n");
-				ast_agi_send(agi->fd, chan, "%s", c->usage);
+				ast_agi_send(agi->fd, chan, "%s\n", c->usage);
 				ast_agi_send(agi->fd, chan, "520 End of proper usage.\n");
 			}
 

-- 
To view, visit https://gerrit.asterisk.org/5699
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If190f1e9e37fe215fed95897d78d4a6e142b0020
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list