[Asterisk-code-review] res format attr h26x.c: Skip leading blanks in fmtp attributes (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue May 23 10:24:05 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5689 )

Change subject: res_format_attr_h26x.c: Skip leading blanks in fmtp attributes
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/5689/1/res/res_format_attr_h263.c
File res/res_format_attr_h263.c:

Line 161: 		attrib = ast_skip_blanks(attrib);
How about using ast_strip() instead to make sure that there are no leading or trailing blanks.  That way we could handle this:  "a=fmtp:99 profile-level-id=42801F ; packetization-mode=1"


https://gerrit.asterisk.org/#/c/5689/1/res/res_format_attr_h264.c
File res/res_format_attr_h264.c:

Line 189: 		attrib = ast_skip_blanks(attrib);
same


-- 
To view, visit https://gerrit.asterisk.org/5689
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44cb2e4fef5c73dc541a29da79cb0e19c22d9cc
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list