[Asterisk-code-review] app queue: Fix members showing as being in call when not. (asterisk[13])

[Joshua Colp]

Hello Kevin Harwell, George Joseph, Jenkins2, Sean Bright,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5639

to look at the new patch set (#4).

Change subject: app_queue: Fix members showing as being in call when not.
......................................................................

app_queue: Fix members showing as being in call when not.

A change was done which added an 'in_call' flag to queue
members that was set to true while talking to an agent.
Unfortunately in practice this does not accurately reflect
whether they are talking to an agent or not. If a Local
channel is involved and a transfer is performed then the
app_queue application would incorrectly think the agent
was still in a call with the caller. This was done to
fix a race condition between an agent becoming available
by device state and the checking of the last call information
for the wrapup time. There was a small window where the
last call information would be the previous value instead
of the new one.

This change goes about fixing the original issue in a
different way by considering the call completed if device
state is received which would make the agent available
and if they are currently in a call. If this occurs the
last call information is updated before the agent becomes
available ensuring that old information is not present
when checking if the member should be called. This also
improves the transfer situation by actually updating
and enforcing the wrapup time.

ASTERISK-26399
ASTERISK-26400
ASTERISK-26715
ASTERISK-26975

Change-Id: Ife1cb686e3173b3a6d368601adef9aff69d4beea
---
M apps/app_queue.c
1 file changed, 48 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/39/5639/4
-- 
To view, visit https://gerrit.asterisk.org/5639
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife1cb686e3173b3a6d368601adef9aff69d4beea
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>