[Asterisk-code-review] core/conversions: Added a string to unsigned integer conversion (asterisk[master])

George Joseph asteriskteam at digium.com
Tue May 16 08:41:47 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5628 )

Change subject: core/conversions: Added a string to unsigned integer conversion
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5628/1/tests/test_conversions.c
File tests/test_conversions.c:

Line 66: 	ast_test_validate(test, ast_str_to_uint(out_of_range, &val));
This test fails on 32-bit systems.  (ast_str_to_uint returns 0)


-- 
To view, visit https://gerrit.asterisk.org/5628
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eaca4a48f8c7b89cc8b5a1f4bed2852fca82bb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list